RE: [PATCH v10 6/9] LPC: Support the LPC host on Hip06/Hip07 with DT bindings

[Gabriele Paoloni]

Hi Randy

> -----Original Message-----
> From: Randy Dunlap [mailto:rdunlap@xxxxxxxxxxxxx]
> Sent: 27 October 2017 17:44
> To: Gabriele Paoloni; catalin.marinas@xxxxxxx; will.deacon@xxxxxxx;
> robh+dt@xxxxxxxxxx; frowand.list@xxxxxxxxx; bhelgaas@xxxxxxxxxx;
> rafael@xxxxxxxxxx; arnd@xxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx;
> lorenzo.pieralisi@xxxxxxx
> Cc: mark.rutland@xxxxxxx; brian.starkey@xxxxxxx; olof@xxxxxxxxx;
> benh@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-
> acpi@xxxxxxxxxxxxxxx; Linuxarm; linux-pci@xxxxxxxxxxxxxxx;
> minyard@xxxxxxx; John Garry; xuwei (O); zhichang.yuan
> Subject: Re: [PATCH v10 6/9] LPC: Support the LPC host on Hip06/Hip07
> with DT bindings
> 
> On 10/27/17 09:11, Gabriele Paoloni wrote:
> > diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig
> > index 2408ea3..358eed3 100644
> > --- a/drivers/bus/Kconfig
> > +++ b/drivers/bus/Kconfig
> > @@ -64,6 +64,15 @@ config BRCMSTB_GISB_ARB
> >  	  arbiter. This driver provides timeout and target abort error
> handling
> >  	  and internal bus master decoding.
> >
> > +config HISILICON_LPC
> > +	bool "Support for ISA I/O space on Hisilicon Hip0X"
> > +	depends on (ARM64 && (ARCH_HISI || COMPILE_TEST))
> > +	select LOGIC_PIO
> > +	select INDIRECT_PIO
> > +	help
> > +	  Driver needed for some legacy ISA devices attached to Low-Pin-
> Count
> > +	  on Hisilicon Hip0X SoC.
> > +
> >  config IMX_WEIM
> >  	bool "Freescale EIM DRIVER"
> >  	depends on ARCH_MXC
> 
> Hi,
> 
> Why bool? why not tristate?

Well for the nature of our HW it would not make much sense to have the
LPC modular. Also you can see in patch 8 the LPC host is "translating"
the resources of its children before these are actually probed and this
is done by acpi_indirectio_scan_init() as part of the ACPI init process.

Thanks
Gab

> 
> --
> ~Randy