Re: [PATCH net-next 1/7] net: dsa: get ports within parsing code

From: Florian Fainelli
Date: Mon Oct 30 2017 - 14:37:40 EST


On 10/27/2017 12:55 PM, Vivien Didelot wrote:
> There is no point into hiding the -EINVAL error code in ERR_PTR from a
> dsa_get_ports function, simply get the "ports" node directly from within
> the dsa_parse_ports_dn function.
>
> This also has the effect to make the pdata and device tree handling code
> symmetrical inside _dsa_register_switch.
>
> At the same time, rename dsa_parse_ports_dn to dsa_parse_ports_of
> because _of is a more common suffix for device tree parsing functions.
>
> Signed-off-by: Vivien Didelot <vivien.didelot@xxxxxxxxxxxxxxxxxxxx>

Reviewed-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
--
Florian