Re: [PATCH] usb: musb: dsps: remove the duplicated timer

From: Greg Kroah-Hartman
Date: Mon Oct 30 2017 - 17:44:10 EST


On Mon, Oct 30, 2017 at 02:29:54PM -0700, Kees Cook wrote:
> On Mon, Oct 30, 2017 at 9:29 AM, Bin Liu <b-liu@xxxxxx> wrote:
> > Now struct musb has the timer (dev_timer) for glue drivers, so let's
> > remove the duplicated timer defined in dsps glue driver, and use
> > dev_timer defined in struct musb.
> >
> > Signed-off-by: Bin Liu <b-liu@xxxxxx>
>
> Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx>
>
> Thanks for this; it wasn't clear to me if both timers needed to exist
> (i.e. glue operated independently from the musb object), so I didn't
> make this change myself.
>
> Greg, it probably makes sense to just take both patches. Does that work for you?

Yes, I can do that, thanks.

greg k-h