Re: [PATCH] Check all .c files for bad kernel-doc comments
From: Jani Nikula
Date: Tue Oct 31 2017 - 04:11:57 EST
On Mon, 30 Oct 2017, Matthew Wilcox <willy@xxxxxxxxxxxxx> wrote:
> On Mon, Oct 30, 2017 at 05:19:18PM +0200, Jani Nikula wrote:
>> Related, there was also a script to do reStructuredText lint style
>> checks in addition to the kernel-doc checks using make CHECK and
>> C=1. See http://mid.mail-archive.com/87h98quc1w.fsf@xxxxxxxxx
>
> I don't really care which patch goes in. If I understand your python
> script correctly, it relies on having various python packages installed.
> Unless we're going to switch kernel-doc over to being written in python,
> I'd prefer to not require additional dependencies.
I think your patch has a much better chance of getting enabled by
default in the long run, so I'd prefer that. I've also kind of dropped
the ball on my script... but thought it might be interesting.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center