Re: [PATCH] hv: kvp: Avoid reading past allocated blocks from KVP file

From: Greg KH
Date: Tue Oct 31 2017 - 04:42:45 EST


On Mon, Oct 30, 2017 at 05:08:03PM -0700, Long Li wrote:
> From: Paul Meyer <Paul.Meyer@xxxxxxxxxxxxx>
>
> While reading in more than one block (50) of KVP records, the allocation goes
> per block, but the reads used the total number of allocated records (without
> resetting the pointer/stream). This causes the records buffer to overrun when
> the refresh reads more than one block over the previous capacity (e.g. reading
> more than 100 KVP records whereas the in-memory database was empty before).

Please wrap changelogs at 72 columns like your editor asked you to...

>
> Fix this by reading the correct number of KVP records from file each time.
>
> Signed-off-by: Paul Meyer <Paul.Meyer@xxxxxxxxxxxxx>
> ---

Why is your name not also on the signed-off-by chain if you are
forwarding on a patch from someone else?

Is this patch also needed on stable kernels?

thanks,

greg k-h