Re: [PATCH] crypto: testmgr: don't allocate IV on stack

[Horia Geantă]

On 10/31/2017 10:00 AM, Herbert Xu wrote:
> On Tue, Oct 31, 2017 at 07:56:26AM +0000, Gilad Ben-Yossef wrote:
>> The IV was allocated on the stack in testmgr skcipher tests.
>> Since HW based tfm providers need to DMA the IV to the HW,
>> this leads to problems and is detected by the DMA-API debug
>> code.
>>
>> Fix it by allocating the IV using kmalloc instead.
>>
>> Signed-off-by: Gilad Ben-Yossef <gilad@xxxxxxxxxxxxx>
Gilad, you're not the only one who bumped into this issue:
https://www.mail-archive.com/linux-crypto@xxxxxxxxxxxxxxx/msg23074.html
not to mention previous patches that have been accepted:
96692a7305c4 crypto: tcrypt - do not allocate iv on stack for aead speed
tests
9bac019dad80 crypto: testmgr - Fix DMA-API warning
and so on.

> 
> The driver that is mapping the IV directly should be fixed instead.
> Only input that is given in the form of SG lists can be mapped.
> Everything else should be copied if they need to go over DMA.
> 
Herbert, wouldn't it make more sense to follow your previous suggestion:
"Perhaps we should change the API so that it gets passed in as an
SG list."
https://www.mail-archive.com/linux-crypto@xxxxxxxxxxxxxxx/msg23082.html

Thanks,
Horia