Re: [PATCH] net: hso: remove redundant unused variable dev

From: Johan Hovold
Date: Tue Oct 31 2017 - 09:22:53 EST


On Tue, Oct 31, 2017 at 12:01:47PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> The pointer dev is being assigned but is never used, hence it is
> redundant and can be removed. Cleans up clang warning:
>
> drivers/net/usb/hso.c:2280:2: warning: Value stored to 'dev' is
> never read

You could also have mentioned that it was a leftover since commit
4134069f3ea6 ("hso: Use static attribute groups for sysfs entry").

> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Reviewed-by: Johan Hovold <johan@xxxxxxxxxx>

Thanks,
Johan