Re: [PATCH] platform: x86: dell-smo8800: remove redundant assignments to byte_data

From: Andy Shevchenko
Date: Tue Oct 31 2017 - 09:48:05 EST


On Tue, Oct 31, 2017 at 1:03 PM, Colin King <colin.king@xxxxxxxxxxxxx> wrote:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> Variable byte_data is being initialized and re-assigned with values that
> are never read. Remove these as these redundant assignments. Cleans up
> clang warning:
>
> drivers/platform/x86/dell-smo8800.c:106:2: warning: Value stored to 'byte_data'
> is never read

Thanks for the patch.

As I read a code it was from the beginning like this. I dunno what was
a motivation of this pieces, thus I would like to hear Pali.

Per se patch looks pretty much good to me.

--
With Best Regards,
Andy Shevchenko