Re: Sony-laptop: Use common error handling code in sony_nc_setup_rfkill()

From: SF Markus Elfring
Date: Tue Oct 31 2017 - 12:57:06 EST


>> I performed another simple software refactoring.
>
> Which is _useless_ per se

I disagree in this case because the goal of a refactoring should be
to adjust something in a desired direction without changing
the provided functionality.


> by the reasons you had been told already _several_ times about.

There can be other reasons why you do not like a concrete change.


> Either you do a real fix (propagate correct error codes
> to upper layers), or just don't bother at all.

Have the involved contributors any preferences on organisation
of corresponding update steps?

* Correct exception handling first and then apply the shown
source code reduction again.

* Combine better exception handling with smaller code
in one patch.

* Addition of the tag âFixesâ in the commit message?

Regards,
Markus