Re: [PATCH] scsi: qla2xxx: Convert timers to use timer_setup()

From: Madhani, Himanshu
Date: Tue Oct 31 2017 - 14:03:55 EST


Hi Martin/Kees,

> On Oct 31, 2017, at 8:49 AM, Martin K. Petersen <martin.petersen@xxxxxxxxxx> wrote:
>
>
> Kees,
>
>> In preparation for unconditionally passing the struct timer_list
>> pointer to all timer callbacks, switch to using the new timer_setup()
>> and from_timer() to pass the timer pointer explicitly.
>
> Cavium folks: Please verify!
>

Iâve checked on my setup and i am seeing regression with this patch applied.

Driver load locks up the system with this patch applied.

NACK

> Reviewed-by: Martin K. Petersen <martin.petersen@xxxxxxxxxx>
>
> --
> Martin K. Petersen Oracle Linux Engineering

Thanks,
- Himanshu