Re: [PATCH 2/2] perf tools: Show correct function name for srcline of callchains

[Namhyung Kim]

Hi Milian,

On Wed, Nov 01, 2017 at 10:57:12AM +0100, Milian Wolff wrote:
> On Tuesday, October 31, 2017 3:06:54 AM CET Namhyung Kim wrote:
> > When libbfd is not used, it doesn't show proper function name and reuse
> > the original symbol of the sample.  That's because it passes the
> > original sym to inline_list__append().  As `addr2line -f` returns
> > function names as well, use that to create ad inline_sym and pass it to
> > inline_list__append().
> 
> Typo above: "ad" -> "and"

I think it's "an" instead of "and". :)

> 
> Otherwise these patches look fine to me
> 
> Reviewed-by: Milian Wolff <milian.wolff@xxxxxxxx>

Thanks,
Namhyung