Re: [PATCH v4 05/13] irqchip: add initial support for ompic
From: Stafford Horne
Date: Wed Nov 01 2017 - 08:17:23 EST
On Mon, Oct 30, 2017 at 06:11:40AM +0000, Marc Zyngier wrote:
> On Mon, Oct 30 2017 at 1:18:06 pm GMT, Stafford Horne <shorne@xxxxxxxxx> wrote:
> > On Mon, Oct 30, 2017 at 02:29:18AM +0000, Marc Zyngier wrote:
> >> On Mon, Oct 30 2017 at 8:11:15 am GMT, Stafford Horne <shorne@xxxxxxxxx> wrote:
> >> > From: Stefan Kristiansson <stefan.kristiansson@xxxxxxxxxxxxx>
> >> >
> >> > IPI driver for the Open Multi-Processor Interrupt Controller (ompic) as
> >> > described in the Multi-core support section of the OpenRISC 1.2
> >> > architecture specification:
> >> >
> >> > https://github.com/openrisc/doc/raw/master/openrisc-arch-1.2-rev0.pdf
> >> >
> >> > Each OpenRISC core contains a full interrupt controller which is used in
> >> > the SMP architecture for interrupt balancing. This IPI device, the
> >> > ompic, is the only external device required for enabling SMP on
> >> > OpenRISC.
> >> >
> >> > Pending ops are stored in a memory bit mask which can allow multiple
> >> > pending operations to be set and serviced at a time. This is mostly
> >> > borrowed from the alpha IPI implementation.
> >> >
> >> > Cc: Marc Zyngier <marc.zyngier@xxxxxxx>
> >> > Acked-by: Rob Herring <robh@xxxxxxxxxx>
> >> > Signed-off-by: Stefan Kristiansson <stefan.kristiansson@xxxxxxxxxxxxx>
> >> > [shorne@xxxxxxxxx: converted ops to bitmask, wrote commit message]
> >> > Signed-off-by: Stafford Horne <shorne@xxxxxxxxx>
> >>
> >> Reviewed-by: Marc Zyngier <marc.zyngier@xxxxxxx>
> >
> > Thanks
> >
> >> Side question: what is your merge strategy for this? I can take it
> >> through the irqchip tree as it is standalone, but I'm open to other
> >> suggestions.
> >
> > For me its easier if I just take it through the openrisc tree, as
> > there are dependencies between this series and the irqchip driver.
> > If you are ok with that I can make a note to Linus indicating so in
> > the pull request.
>
> No problem, that's OK with me.
Acknowledged
> > My plan is to send this series during the 4.15 merge window.
>
> Make sure this is in -next (when it comes back to life...).
Its there now, and it looks like -next is almost back to life.
-Stafford