RE: [Patch v5 02/21] CIFS: SMBD: Establish SMB Direct connection

[Long Li]

> -----Original Message-----
> From: Pavel Shilovsky [mailto:piastryyy@xxxxxxxxx]
> Sent: Wednesday, November 1, 2017 10:19 AM
> To: Long Li <longli@xxxxxxxxxxxxx>
> Cc: Steve French <sfrench@xxxxxxxxx>; linux-cifs <linux-
> cifs@xxxxxxxxxxxxxxx>; samba-technical <samba-technical@xxxxxxxxxxxxxxx>;
> Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>; linux-
> rdma@xxxxxxxxxxxxxxx; Tom Talpey <ttalpey@xxxxxxxxxxxxx>; Matthew
> Wilcox <mawilcox@xxxxxxxxxxxxx>; Stephen Hemminger
> <sthemmin@xxxxxxxxxxxxx>; Long Li <longli@xxxxxxxxxxxxx>
> Subject: Re: [Patch v5 02/21] CIFS: SMBD: Establish SMB Direct connection
> 
> 2017-10-18 16:09 GMT-07:00 Long Li <longli@xxxxxxxxxxxxxxxxxxxxxx>:
> > From: Long Li <longli@xxxxxxxxxxxxx>
> >
> > Add code to implement the core functions to establish a SMB Direct
> connection.
> >
> > 1. Establish an RDMA connection to SMB server.
> > 2. Negotiate and setup SMB Direct protocol.
> > 3. Implement idle connection timer and credit management.
> >
> > SMB Direct is enabled by setting CONFIG_CIFS_SMB_DIRECT.
> >
> > Add to Kconfig and Makefile to enable building SMB Direct.
> >
> > Signed-off-by: Long Li <longli@xxxxxxxxxxxxx>
> > ---
> >  fs/cifs/Kconfig     |    7 +
> >  fs/cifs/Makefile    |    2 +
> >  fs/cifs/smbdirect.c | 1576
> > +++++++++++++++++++++++++++++++++++++++++++++++++++
> >  fs/cifs/smbdirect.h |  265 +++++++++
> >  4 files changed, 1850 insertions(+)
> >
> > diff --git a/fs/cifs/Kconfig b/fs/cifs/Kconfig index f724361..cb7db8d
> > 100644
> > --- a/fs/cifs/Kconfig
> > +++ b/fs/cifs/Kconfig
> > @@ -191,6 +191,13 @@ config CIFS_SMB311
> >           This dialect includes improved security negotiation features.
> >           If unsure, say N
> >
> > +config CIFS_SMB_DIRECT
> > +       bool "SMB Direct support (Experimental)"
> > +       depends on CIFS && INFINIBAND
> > +       help
> > +         Enables SMB Direct experimental support for SMB 3.0, 3.02 and 3.1.1.
> > +         SMB Direct allows transferring SMB packets over RDMA.
> > +
> 
> Please add "If unsure, say N."

Sure, will make the change.

> 
> --
> Best regards,
> Pavel Shilovsky