Re: [RFC V7 2/2] OPP: Allow "opp-hz" and "opp-microvolt" to contain magic values
From: Viresh Kumar
Date: Thu Nov 02 2017 - 00:49:34 EST
On 01-11-17, 15:39, Rob Herring wrote:
> On Tue, Oct 31, 2017 at 9:17 PM, Viresh Kumar <viresh.kumar@xxxxxxxxxx> wrote:
> > On 31 October 2017 at 16:02, Rob Herring <robh+dt@xxxxxxxxxx> wrote:
> >> Why not a new property for magic values? opp-magic? Don't we want to
> >> know when we have magic values?
> >
> > I have kept a separate property since beginning (domain-performance-state)
> > and moved to using these magic values in the existing field because of the
> > suggestion Kevin gave earlier.
> >
> > https://marc.info/?l=linux-kernel&m=149306082218001&w=2
> >
> > I am not sure what to do now :)
>
> Okay, I guess reusing the properties is fine.
Okay, great.
> >> Wouldn't magic values in opp-hz get propagated to user space?
> >
> > The OPP core puts them in debugfs just to know how the OPPs are
> > set. Otherwise, I am not sure that the power domain core/drivers would
> > be exposing that to user space.
>
> I was thinking thru the cpufreq interface, but I guess this is not for cpus.
Oh no. That's not the target here for sure.
--
viresh