Re: [PATCH] sh: remove pointless select of KBUILD_DEFCONFIG

[Masahiro Yamada]

Hi Geert,

2017-11-02 18:18 GMT+09:00 Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>:
> Hi Yamada-san,
>
> On Wed, Oct 4, 2017 at 11:33 AM, Masahiro Yamada
> <yamada.masahiro@xxxxxxxxxxxxx> wrote:
>> KBUILD_DEFCONFIG := shx3_defconfig
>>
>> is never used in a sensible way.  KBUILD_DEFCONFIG specifies the
>> defconfig file used by "make defconfig", but CONFIG_SUPERH32 is
>> never set when building config targets.
>>
>> Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
>> ---
>>
>>  arch/sh/Makefile | 3 +--
>>  1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/arch/sh/Makefile b/arch/sh/Makefile
>> index 280bbff..c937ec0 100644
>> --- a/arch/sh/Makefile
>> +++ b/arch/sh/Makefile
>> @@ -96,6 +96,7 @@ defaultimage-$(CONFIG_SH_7619_SOLUTION_ENGINE)        := vmlinux
>>  # Set some sensible Kbuild defaults
>>  boot := arch/sh/boot
>>  KBUILD_IMAGE           := $(boot)/$(defaultimage-y)
>> +KBUILD_DEFCONFIG       := cayman_defconfig
>
> cayman_defconfig is a 64-bit defconfig?
> As the big chunk of SH platforms are 32-bit (are there any 64-bit out in
> the wild?), does it make sense to make a 64-bit defconfig the default?


No.  Seems 32-bit.


$ make ARCH=sh cayman_defconfig && head -n 10 .config
#
# configuration written to .config
#
#
# Automatically generated file; DO NOT EDIT.
# Linux/sh 4.14.0-rc7 Kernel Configuration
#
CONFIG_SUPERH=y
CONFIG_SUPERH32=y
# CONFIG_SUPERH64 is not set
CONFIG_ARCH_DEFCONFIG="arch/sh/configs/shx3_defconfig"
CONFIG_RWSEM_GENERIC_SPINLOCK=y
CONFIG_GENERIC_BUG=y



So, both shx3_defconfig and cayman_defconfig are 32-bit defconfig.

I do not know the point of this ifdef select.

Anyway, my clean-up is to remove the unused line from the Makefile.


>>  #
>>  # Choosing incompatible machines durings configuration will result in
>> @@ -105,14 +106,12 @@ ifdef CONFIG_SUPERH32
>>  UTS_MACHINE            := sh
>>  BITS                   := 32
>>  LDFLAGS_vmlinux                += -e _stext
>> -KBUILD_DEFCONFIG       := shx3_defconfig
>>  else
>>  UTS_MACHINE            := sh64
>>  BITS                   := 64
>>  LDFLAGS_vmlinux                += --defsym phys_stext=_stext-$(CONFIG_PAGE_OFFSET) \
>>                            --defsym phys_stext_shmedia=phys_stext+1 \
>>                            -e phys_stext_shmedia
>> -KBUILD_DEFCONFIG       := cayman_defconfig
>>  endif
>>
>>  ifdef CONFIG_CPU_LITTLE_ENDIAN
>
> Gr{oetje,eeting}s,
>


-- 
Best Regards
Masahiro Yamada