Re: [PATCH] drivers/firmware: psci_checker: Add missing destroy_timer_on_stack()

[Arnd Bergmann]

On Mon, Oct 30, 2017 at 10:48 AM, Lorenzo Pieralisi
<lorenzo.pieralisi@xxxxxxx> wrote:
> On Mon, Oct 30, 2017 at 10:17:54AM +0100, Arnd Bergmann wrote:
>> On Tue, Oct 24, 2017 at 5:02 PM, Lorenzo Pieralisi
>> <lorenzo.pieralisi@xxxxxxx> wrote:
>> > The PSCI checker suspend_test_thread() function (ie executed for the
>> > suspend test) requires an on-stack timer to carry out the test it
>> > executes; it sets it up through the setup_timer_on_stack() API.
>> >
>> > setup_timer_on_stack() requires its counterpart destroy_timer_on_stack()
>> > to be called when the timer is disposed of but the PSCI checker code is
>> > currently missing that call, leaving the timer object in an incosistent
>> > state when the PSCI checker stops the thread executing the suspend
>> > test.
>> >
>> > Add the missing destroy_timer_on_stack() call to fix the omission.
>> >
>> > Fixes: ea8b1c4a6019 ("drivers: psci: PSCI checker module")
>> > Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@xxxxxxx>
>> > Reported-by: Kees Cook <keescook@xxxxxxxxxxxx>
>> > Cc: Kees Cook <keescook@xxxxxxxxxxxx>
>> > Cc: Mark Rutland <mark.rutland@xxxxxxx>
>>
>> Hi Lorenzo,
>>
>> You addressed the patch 'To: arm@xxxxxxxxxx', but I'm not entirely
>> sure what to do with it, it would be nice to be a little more explicit whether
>> you want us to apply the patch directly or just review it, and which trees
>> you want it to get merged into.
>
> Yes, I was about to reply to you - I should have added some comments
> to the patch itself, apologies.

Applied to next/drivers now, thanks!

      Arnd