Re: [PATCH] pmbus: added possibility to change timeout for device update
From: Guenter Roeck
Date: Thu Nov 02 2017 - 15:21:18 EST
On Thu, Nov 02, 2017 at 05:17:21PM +0100, Romain Porte wrote:
> On 02/11/2017 14:58, Guenter Roeck wrote:
> >NACK, I'd rather drop the caching entirely, and possibly convert the
> >driver to
> >regmap for caching non-volatile registers.
> I need to familiarize myself with regmap then, it looks like a nice
> abstraction to have.
>
> Do you think I can propose an intermediate patch for removing the cache
> support? (both time-based and data->valid based, so that every read actually
> performs a read, everytime)
>
If you manage to do that, yes. That should limit reads to required reads,
not just drop ->valid and re-read every register for each attribute
access. Essentially, pmbus_update_device() should be completely gone.
That isn't easy to implement, which is why I never got to doing it.
Guenter