Re: [PATCH] netfilter: ipvs: Convert timers to use timer_setup()
From: Kees Cook
Date: Thu Nov 02 2017 - 18:12:02 EST
On Thu, Nov 2, 2017 at 7:42 AM, Simon Horman <horms@xxxxxxxxxxxx> wrote:
> On Tue, Oct 24, 2017 at 10:07:03PM +0300, Julian Anastasov wrote:
>>
>> Hello,
>>
>> On Tue, 24 Oct 2017, Kees Cook wrote:
>>
>> > In preparation for unconditionally passing the struct timer_list pointer to
>> > all timer callbacks, switch to using the new timer_setup() and from_timer()
>> > to pass the timer pointer explicitly.
>> >
>> > Cc: Wensong Zhang <wensong@xxxxxxxxxxxx>
>> > Cc: Simon Horman <horms@xxxxxxxxxxxx>
>> > Cc: Julian Anastasov <ja@xxxxxx>
>> > Cc: Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>
>> > Cc: Jozsef Kadlecsik <kadlec@xxxxxxxxxxxxxxxxx>
>> > Cc: Florian Westphal <fw@xxxxxxxxx>
>> > Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>
>> > Cc: netdev@xxxxxxxxxxxxxxx
>> > Cc: lvs-devel@xxxxxxxxxxxxxxx
>> > Cc: netfilter-devel@xxxxxxxxxxxxxxx
>> > Cc: coreteam@xxxxxxxxxxxxx
>> > Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx>
>>
>> Looks good to me,
>>
>> Acked-by: Julian Anastasov <ja@xxxxxx>
>
> Signed-off-by: Simon Horman <horms@xxxxxxxxxxxx>
>
> Pablo, could you take this?
If it's helpful, we could take this via the timers tree. Either way. :) Thanks!
-Kees
--
Kees Cook
Pixel Security