[PATCH] platform/x86: hp-wmi: Fix tablet mode detection for convertibles

From: Stefan BrÃns
Date: Thu Nov 02 2017 - 22:02:24 EST


Commit f9cf3b2880cc ("platform/x86: hp-wmi: Refactor dock and tablet
state fetchers") consolidated the methods for docking and laptop mode
detection, but omitted to apply the correct mask for the laptop mode
(it always uses the constant for docking).

Signed-off-by: Stefan BrÃns <stefan.bruens@xxxxxxxxxxxxxx>

---

This change is untested, but restores the previous behaviour.
---
drivers/platform/x86/hp-wmi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/x86/hp-wmi.c b/drivers/platform/x86/hp-wmi.c
index b4ed3dc983d5..b4224389febe 100644
--- a/drivers/platform/x86/hp-wmi.c
+++ b/drivers/platform/x86/hp-wmi.c
@@ -297,7 +297,7 @@ static int hp_wmi_hw_state(int mask)
if (state < 0)
return state;

- return state & 0x1;
+ return !!(state & mask);
}

static int __init hp_wmi_bios_2008_later(void)
--
2.14.3