Re: [PATCH v2 0/3] Sony-laptop: Adjustments for sony_nc_setup_rfkill()

[SF Markus Elfring]

> I have applied first two,

Thanks for another change acceptance.


> the last one is subject to discuss a necessity of it.

I can offer another bit of information for this software development discussion.

The following build settings were active in my âMakefileâ for this Linux test case.

â
HOSTCFLAGS   = -Wall -Wmissing-prototypes -Wstrict-prototypes -O0 -fomit-frame-pointer -std=gnu89
â


The affected source file can be compiled for the processor architecture âx86_64â
by a tool like âGCC 6.4.1+r251631-1.3â from the software distribution
âopenSUSE Tumbleweedâ with the following command example.

my_cc=/usr/bin/gcc-6 \
&& my_module=drivers/platform/x86/sony-laptop.ko \
&& git checkout ':/^Sony-laptop: Delete an unnecessary variable initialisation in sony_nc_setup_rfkill' \
&& make -j4 CC="${my_cc}" HOSTCC="${my_cc}" allmodconfig "${my_module}" \
&& size "${my_module}" \
&& git checkout ':/^Sony-laptop: Use common error handling code in sony_nc_setup_rfkill' \
&& make -j4 CC="${my_cc}" HOSTCC="${my_cc}" allmodconfig "${my_module}" \
&& size "${my_module}"


Do you find the following details useful for further clarification?

text: -32
data: 0
bss:  0

Regards,
Markus