Re: watchdog: alim1535_wdt: mark expected switch fall-through

From: Guenter Roeck
Date: Fri Nov 03 2017 - 09:33:40 EST


On Thu, Nov 02, 2017 at 02:25:09PM -0500, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Notice that in this particular case I replaced "Fall" with a proper
> "fall through" comment, which is what GCC is expecting to find.
>
> Signed-off-by: Gustavo A. R. Silva <garsilva@xxxxxxxxxxxxxx>

Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>

> ---
> drivers/watchdog/alim1535_wdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/alim1535_wdt.c b/drivers/watchdog/alim1535_wdt.c
> index 3a17fbd..60f0c2e 100644
> --- a/drivers/watchdog/alim1535_wdt.c
> +++ b/drivers/watchdog/alim1535_wdt.c
> @@ -223,8 +223,8 @@ static long ali_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
> if (ali_settimer(new_timeout))
> return -EINVAL;
> ali_keepalive();
> - /* Fall */
> }
> + /* fall through */
> case WDIOC_GETTIMEOUT:
> return put_user(timeout, p);
> default: