Re: [PATCH] cdrom: always select BLK_SCSI_REQUEST

From: Arnd Bergmann
Date: Fri Nov 03 2017 - 19:02:29 EST


On Fri, Nov 3, 2017 at 11:55 PM, Bart Van Assche <Bart.VanAssche@xxxxxxx> wrote:
> On Fri, 2017-11-03 at 23:48 +0100, Arnd Bergmann wrote:
>> When CDROM is enabled, but nothing else selects BLK_SCSI_REQUEST,
>> we get this link error:
>>
>> cdrom.c:(.text+0x7a18): undefined reference to `scsi_cmd_blk_ioctl'
>
> Hello Arnd,
>
> Can you check whether this issue still occurs with Jens' for-4.15/block
> branch (commit a116895fc7b6)?

I haven't tried, but that commit also look like a correct fix for this problem.
We could add my patch as a micro-cleanup on top, but it should not
be required any more now.

I'll drop my patch from the randconfig build and will let you know in
case the problem (or something else) comes back.

Arnd