Re: [PATCH 0/4] x86, kbuild: Some improvements for fdimage/isoimage generation

[Ingo Molnar]

* changbin.du@xxxxxxxxx <changbin.du@xxxxxxxxx> wrote:

> From: Changbin Du <changbin.du@xxxxxxxxx>
> 
> This serias is a expansion of below original patch after discussion with Ingo
> and Yamada.
> [PATCH] x86, build: Improve the isolinux searching of isoimage generation
> 
> Changbin Du (4):
>   x86, build: Fact out fdimage/isoimage generation commands to
>     standalone script
>   x86, build: Add new paths for isolinux.bin and ldlinux.c32
>   x86, build: Specify -input-charset=utf-8 for mkisofs
>   x86, boot: Add some generated files to the .gitignore file
> 
>  arch/x86/boot/.gitignore  |   3 ++
>  arch/x86/boot/Makefile    |  59 +++++------------------
>  arch/x86/boot/genimage.sh | 119 ++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 133 insertions(+), 48 deletions(-)
>  create mode 100644 arch/x86/boot/genimage.sh

Very nice - it looks good to me with the edits I suggested.

Would be nice if the kbuild maintainers could take a look as well - is this how 
boot image construction should be done at the arch level?

Thanks,

	Ingo