Re: [PATCH] net/mlx5e/core/en_fs: fix pointer dereference after free in mlx5e_execute_l2_action

[Gustavo A. R. Silva]

Hi Saeed,

Quoting Saeed Mahameed <saeedm@xxxxxxxxxxxxxxxxxx>:

> On Sat, Nov 4, 2017 at 8:54 PM, Gustavo A. R. Silva
> <garsilva@xxxxxxxxxxxxxx> wrote:
> > hn is being kfree'd in mlx5e_del_l2_from_hash and then dereferenced
> > by accessing hn->ai.addr
> >
> > Fix this by copying the MAC address into a local variable for its safe use
> > in all possible execution paths within function mlx5e_execute_l2_action.
> >
> > Addresses-Coverity-ID: 1417789
> > Fixes: eeb66cdb6826 ("net/mlx5: Separate between E-Switch and MPFS")
> > Signed-off-by: Gustavo A. R. Silva <garsilva@xxxxxxxxxxxxxx>
>
> Acked-by: Saeed Mahameed <saeedm@xxxxxxxxxxxx>
>
> Looks good.
> Thank you Gustavo.

Glad to help.

Thanks
--
Gustavo A. R. Silva