Re: [PATCH] x86: kvm: mmu: make kvm_mmu_clear_all_pte_masks static

[David Hildenbrand]

On 03.11.2017 19:52, Gimcuan Hui wrote:
> The kvm_mmu_clear_all_pte_masks interface is only used by kvm_mmu_module_init
> locally, and does not need to be called by other module, make it static.
> 
> This patch cleans up sparse warning:
> symbol 'kvm_mmu_clear_all_pte_masks' was not declared. Should it be static?
> 
> Signed-off-by: Gimcuan Hui <gimcuan@xxxxxxxxx>
> ---
>  arch/x86/kvm/mmu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c
> index 7a69cf053711..6b247d64926e 100644
> --- a/arch/x86/kvm/mmu.c
> +++ b/arch/x86/kvm/mmu.c
> @@ -367,7 +367,7 @@ void kvm_mmu_set_mask_ptes(u64 user_mask, u64 accessed_mask,
>  }
>  EXPORT_SYMBOL_GPL(kvm_mmu_set_mask_ptes);
>  
> -void kvm_mmu_clear_all_pte_masks(void)
> +static void kvm_mmu_clear_all_pte_masks(void)
>  {
>  	shadow_user_mask = 0;
>  	shadow_accessed_mask = 0;
> 

Reviewed-by: David Hildenbrand <david@xxxxxxxxxx>

-- 

Thanks,

David / dhildenb