Re: [PATCH 0001/0001] format idle IP output func+offset/length

[Petr Mladek]

On Mon 2017-11-06 18:52:03, Liu, Changcheng wrote:
> kaslr feature is enabled in kernel.
> Remove kernel text address when dumping idle IP info
> 
> Signed-off-by: Liu Changcheng <changcheng.liu@xxxxxxxxx>
> Signed-off-by: Jerry Liu <primerlink@xxxxxxxxx>
> 
> diff --git a/lib/nmi_backtrace.c b/lib/nmi_backtrace.c
> index 0bc0a35..9cc4178 100644
> --- a/lib/nmi_backtrace.c
> +++ b/lib/nmi_backtrace.c
> @@ -92,7 +92,7 @@ bool nmi_cpu_backtrace(struct pt_regs *regs)
>  	if (cpumask_test_cpu(cpu, to_cpumask(backtrace_mask))) {
>  		arch_spin_lock(&lock);
>  		if (regs && cpu_in_idle(instruction_pointer(regs))) {
> -			pr_warn("NMI backtrace for cpu %d skipped: idling at pc %#lx\n",
> +			pr_warn("NMI backtrace for cpu %d skipped: idling at %pS\n",

Yup, removing "pc" makes sense as well.

Reviewed-by: Petr Mladek <pmladek@xxxxxxxx>

Best Regards,
Petr