Re: linux-next: Tree for Nov 6 (amdgpu_virt.c)

[Alex Deucher]

On Mon, Nov 6, 2017 at 12:20 PM, Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:
> On 11/05/2017 11:30 PM, Stephen Rothwell wrote:
>> Hi all,
>>
>> Changes since 20171103:
>>
>
> on i386, when CONFIG_MODULES is not set:
>
>   CC      drivers/gpu/drm/amd/amdgpu/amdgpu_virt.o
> In file included from ../arch/x86/include/asm/atomic.h:5:0,
>                  from ../include/linux/atomic.h:5,
>                  from ../drivers/gpu/drm/amd/amdgpu/amdgpu.h:31,
>                  from ../drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c:24:
> ../drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c: In function 'amdgpu_virt_init_data_exchange':
> ../drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c:331:20: error: dereferencing pointer to incomplete type
>      if (THIS_MODULE->version != NULL)
>                     ^
> ../include/linux/compiler.h:58:30: note: in definition of macro '__trace_if'
>   if (__builtin_constant_p(!!(cond)) ? !!(cond) :   \
>                               ^
> ../drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c:331:5: note: in expansion of macro 'if'
>      if (THIS_MODULE->version != NULL)
>      ^
> ../drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c:331:20: error: dereferencing pointer to incomplete type
>      if (THIS_MODULE->version != NULL)
>                     ^
> ../include/linux/compiler.h:58:42: note: in definition of macro '__trace_if'
>   if (__builtin_constant_p(!!(cond)) ? !!(cond) :   \
>                                           ^
> ../drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c:331:5: note: in expansion of macro 'if'
>      if (THIS_MODULE->version != NULL)
>      ^
> ../drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c:331:20: error: dereferencing pointer to incomplete type
>      if (THIS_MODULE->version != NULL)
>                     ^
> ../include/linux/compiler.h:69:16: note: in definition of macro '__trace_if'
>    ______r = !!(cond);     \
>                 ^
> ../drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c:331:5: note: in expansion of macro 'if'
>      if (THIS_MODULE->version != NULL)
>      ^
> ../drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c:332:29: error: dereferencing pointer to incomplete type
>       strcpy(str, THIS_MODULE->version);
>                              ^
> ../scripts/Makefile.build:314: recipe for target 'drivers/gpu/drm/amd/amdgpu/amdgpu_virt.o' failed
> make[5]: *** [drivers/gpu/drm/amd/amdgpu/amdgpu_virt.o] Error 1
>
>
>
> Reported-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>

Thanks.  Fixed in:
https://cgit.freedesktop.org/~airlied/linux/commit/?h=drm-next&id=e477e940dad1836c6f6d23353e424665b9316b6e

Alex