Re: [PATCH] selftests: futex: fix compilation error

From: lei yang
Date: Mon Nov 06 2017 - 20:19:25 EST




On 2017å11æ07æ 07:48, Shuah Khan wrote:
On 11/06/2017 04:45 PM, Shuah Khan wrote:
On 11/05/2017 09:03 PM, Lei Yang wrote:
I run into below error when building futext
/bin/sh: -c: line 5: syntax error: unexpected end of file

the closing ";" and "\" are necessary.
My OS is "Ubuntu 14.04.5 LTS"

Signed-off-by: Lei Yang <Lei.Yang@xxxxxxxxxxxxx>
---
tools/testing/selftests/futex/Makefile | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/testing/selftests/futex/Makefile b/tools/testing/selftests/futex/Makefile
index f0c0369..943f3a2 100644
--- a/tools/testing/selftests/futex/Makefile
+++ b/tools/testing/selftests/futex/Makefile
@@ -11,9 +11,9 @@ all:
BUILD_TARGET=$(OUTPUT)/$$DIR; \
mkdir $$BUILD_TARGET -p; \
make OUTPUT=$$BUILD_TARGET -C $$DIR $@;\
- if [ -e $$DIR/$(TEST_PROGS) ]; then
- rsync -a $$DIR/$(TEST_PROGS) $$BUILD_TARGET/;
- fi
+ if [ -e $$DIR/$(TEST_PROGS) ]; then \
+ rsync -a $$DIR/$(TEST_PROGS) $$BUILD_TARGET/; \
+ fi \
done
override define RUN_TESTS

Hmm. I don't see this error on linux_4.14-rc8?

Can you give more details on the gcc version you are using?

I meant gnumake version? I am not seeing the failure with what I am
using

$ make -v
GNU Make 3.81
Copyright (C) 2006 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.
There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A
PARTICULAR PURPOSE.

This program built for x86_64-pc-linux-gnu


Lei


thanks,
-- Shuah