Re: [PATCH v2 1/4] x86, build: Factor out fdimage/isoimage generation commands to standalone script

[Du, Changbin]

On Tue, Nov 07, 2017 at 11:20:29AM +0100, Ingo Molnar wrote:
> 
> * changbin.du@xxxxxxxxx <changbin.du@xxxxxxxxx> wrote:
> 
> > From: Changbin Du <changbin.du@xxxxxxxxx>
> > 
> > The build message for fdimage/isoimage are pretty unstructured. The raw
> > shell command blocks are printed. We can improve them as regular build
> > system messages. Besides, writing commands in a shell script is much more
> > easy than in a Makefile.
> > 
> > See Ingo's suggestion here https://lkml.org/lkml/2017/10/31/124.
> > 
> > This patch factors out the commands used for fdimage/isoimage generation
> > from arch/x86/boot/Makefile to a new script arch/x86/boot/genimage.sh.
> > Then it adds the new kbuild command 'genimage' which invokes the new script.
> > All fdimages/isoimage files are now generated by a call to 'genimage' with
> > different parameters.
> > 
> > Now 'make isoimage' becomes:
> > ...
> > Kernel: arch/x86/boot/bzImage is ready  (#30)
> >   GENIMAGE arch/x86/boot/image.iso
> > Size of boot image is 4 sectors -> No emulation
> >  15.37% done, estimate finish Sun Nov  5 23:36:57 2017
> >  30.68% done, estimate finish Sun Nov  5 23:36:57 2017
> >  46.04% done, estimate finish Sun Nov  5 23:36:57 2017
> >  61.35% done, estimate finish Sun Nov  5 23:36:57 2017
> >  76.69% done, estimate finish Sun Nov  5 23:36:57 2017
> >  92.00% done, estimate finish Sun Nov  5 23:36:57 2017
> > Total translation table size: 2048
> > Total rockridge attributes bytes: 659
> > Total directory bytes: 0
> > Path table size(bytes): 10
> > Max brk space used 0
> > 32608 extents written (63 MB)
> > Kernel: arch/x86/boot/image.iso is ready
> 
> Could we please also do another patch, to make it emit only this by default:
> 
> >   GENIMAGE arch/x86/boot/image.iso
> 
> None of the other messages really matter to the user.
> 
> Maybe emit them when building with V=1 - but none of that info is really 
> interesting IMHO.
> 
Ingo, do you mean that omit below messages?
Size of boot image is 4 sectors -> No emulation
15.37% done, estimate finish Sun Nov  5 23:36:57 2017
...
32608 extents written (63 MB)

These are printed by mkisofs. How about just add '-quite' parameter to it?
Kernel: arch/x86/boot/bzImage is ready  (#75)
GENIMAGE arch/x86/boot/image.iso
Using /usr/lib/ISOLINUX/isolinux.bin
Using /usr/lib/syslinux/modules/bios/ldlinux.c32
Kernel: arch/x86/boot/image.iso is ready

> Thanks,
> 
> 	Ingo

-- 
Thanks,
Changbin Du

Attachment: signature.asc
Description: PGP signature