Re: [PATCH 35/35] perf annotate: Align source and offset lines

[Jiri Olsa]

On Tue, Nov 07, 2017 at 11:10:47AM -0300, Arnaldo Carvalho de Melo wrote:

SNIP

> > Link: http://lkml.kernel.org/n/tip-uamk3iiewlii40o4mlog2cpp@xxxxxxxxxxxxxx
> > Signed-off-by: Jiri Olsa <jolsa@xxxxxxxxxx>
> > ---
> >  tools/perf/util/annotate.c | 7 ++++---
> >  1 file changed, 4 insertions(+), 3 deletions(-)
> > 
> > diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
> > index 2516e53104be..530961a343fc 100644
> > --- a/tools/perf/util/annotate.c
> > +++ b/tools/perf/util/annotate.c
> > @@ -1082,6 +1082,7 @@ static void annotate__branch_printf(struct block_range *br, u64 addr)
> >  	}
> >  }
> >  
> > +#define ADDR_LEN 10
> 
> This doesn't align kernel addresses well, as they will take more
> columns, so I'm trying the patch below, on top of yours, ok?
> 
> I will combine both to elliminate unnecessary churn, ok?

argh.. sounds good, thanks

jirka