Re: WARNING in get_pi_state

From: Dmitry Vyukov
Date: Tue Nov 07 2017 - 09:51:28 EST


On Tue, Oct 31, 2017 at 11:08 AM, Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
> On Tue, Oct 31, 2017 at 12:29:50PM +0300, Dmitry Vyukov wrote:
>> I understand your sentiment, but it's definitely not _at all_. The
>> system compiled this exact code, run it and triggered the bug on it.
>> Do you have suggestions on how to make this code more portable? How
>> does this setup would look on your system?
>
> So I don't see the point of that tun stuff; what was is supposed to do?
>
> All it ever did after creation was flush_tun(), which reads until empty.
> But given nobody would ever write into it, that's an 'expensive' NO-OP.

I've filed https://github.com/google/syzkaller/issues/414 for this. If
the program does not use tun, we will strip that code right away.
Thanks for feedback.