RE: [PATCH 0/2] Account for uncorrectable failures in probing

From: Mario.Limonciello
Date: Tue Nov 07 2017 - 11:17:15 EST


> -----Original Message-----
> From: Limonciello, Mario
> Sent: Friday, November 3, 2017 11:27 AM
> To: dvhart@xxxxxxxxxxxxx; Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
> Cc: LKML <linux-kernel@xxxxxxxxxxxxxxx>; platform-driver-x86@xxxxxxxxxxxxxxx;
> pali.rohar@xxxxxxxxx; Limonciello, Mario <Mario_Limonciello@xxxxxxxx>
> Subject: [PATCH 0/2] Account for uncorrectable failures in probing
>
> Pali raised some concerns around corner case scenarios that probing
> may fail on dell-wmi-descriptor causing dell-wmi and dell-smbios-wmi
> to be stuck in infinite deferred probing loops.
>
> This patch series accounts for that corner case.
>
> Changes since original submission:
> - Add as second patch that catches potential NULL pointer
> - Avoid potential race condition between driver init and calling
> check for if validation successful
> Mario Limonciello (2):
> platform/x86: dell-wmi-descriptor: check if memory was allocated
> platform/x86: dell-*wmi*: Relay failed initial probe to dependent
> drivers
>
> drivers/platform/x86/dell-smbios-wmi.c | 4 ++++
> drivers/platform/x86/dell-wmi-descriptor.c | 16 ++++++++++++++++
> drivers/platform/x86/dell-wmi-descriptor.h | 7 +++++++
> drivers/platform/x86/dell-wmi.c | 5 +++++
> 4 files changed, 32 insertions(+)
>
> --
> 2.14.1

Pali,

Did you have any thoughts on these two patches? I believe they should
account for the concerns you raised regarding the corner cases with
probing in my series.

The series is queued up in the platform-drivers-x86 testing branch and
they are intended to be on top of that.

Thanks,