Re: [PATCH v4 0/4] fix the clock setting for SAR ADC

[Martin Blumenstingl]

Hi Yixun,

On Tue, Nov 7, 2017 at 3:09 PM, Yixun Lan <yixun.lan@xxxxxxxxxxx> wrote:
> patch [1/4]:
>   Fix wrong SARADC/SANA clock gate bit in Meson-GXBB/GXL,
> the published datasheets[4] also has wrong description about this.
>   This patch should be explicitly merged *before* other patches.
>
> patch [2-4/4]:
>   Drop the "sana" clock from SAR ADC module,
I agree with Jerome that patch 2/4 should be applied last.
when I wrote the driver I couldn't get it to work on my GXBB board
(which unfortunately has died since then) because the clocks were
disabled (they weren't enabled by the bootloader). people who are
using an old .dtb would get the same problem again until the clock
driver is merged

>   From the hardware perspective, the SAR ADC module doesn't
> require "sana" clock to wrok. This should apply to all SoC,
> including meson6,8, GXBB, GXL..
thank you for clarifying this!

> Note: the whole patchset series has been tested at GXL-P212 board,
> we haven't got any meson6,8 board to test, so I would appreciate
> if someone (Martin?) could help to confirm it works there.
I can test this on a Meson8b and a Meson8m2 board on the weekend -
I'll let you know about the results


Regards
Martin