RE: [PATCH net-next 1/2] net: hns3: fix a bug when getting phy address from NCL_config file

From: Salil Mehta
Date: Wed Nov 08 2017 - 09:40:51 EST


Hi Andrew,

> -----Original Message-----
> From: Andrew Lunn [mailto:andrew@xxxxxxx]
> Sent: Wednesday, November 08, 2017 2:31 PM
> To: lipeng (Y)
> Cc: davem@xxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; Linuxarm; Zhuangyuzeng (Yisen); Salil Mehta
> Subject: Re: [PATCH net-next 1/2] net: hns3: fix a bug when getting phy
> address from NCL_config file
>
> On Wed, Nov 08, 2017 at 03:52:22PM +0800, Lipeng wrote:
> > From: Fuyun Liang <liangfuyun1@xxxxxxxxxx>
> >
> > Driver gets phy address from NCL_config file and uses the phy address
> > to initialize phydev. There are 5 bits for phy address. And C22 phy
> > address has 5 bits. So 0-31 are all valid address for phy. If there
> > is no phy, it will crash. Because driver always get a valid phy
> address.
>
> Hi Lipeng
>
> Any plans for C45?
Still remember the kernel change required to support C45 discussed with
you some time back :). Will try to push that change as soon as possible.
And yes, we would be pushing the support of the C45 for HNS3 driver as
well after that.

Thanks
Salil