Re: usb/media/em28xx: use-after-free in em28xx_dvb_fini

[Andrey Konovalov]

On Tue, Nov 7, 2017 at 10:18 PM, Gustavo A. R. Silva
<garsilva@xxxxxxxxxxxxxx> wrote:
> Hi Andrey,
>
> Could you please try this patch?
>
> Thank you
>
> Gustavo A. R. Silva

Hi Gustavo,

Still see the crash with your patch.

Thanks!

>
> ---
>  drivers/media/usb/em28xx/em28xx-dvb.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/media/usb/em28xx/em28xx-dvb.c b/drivers/media/usb/em28xx/em28xx-dvb.c
> index 4a7db62..fc3fb92 100644
> --- a/drivers/media/usb/em28xx/em28xx-dvb.c
> +++ b/drivers/media/usb/em28xx/em28xx-dvb.c
> @@ -2073,6 +2073,9 @@ static int em28xx_dvb_fini(struct em28xx *dev)
>         struct em28xx_dvb *dvb;
>         struct i2c_client *client;
>
> +       if (!dev)
> +               return 0;
> +
>         if (dev->is_audio_only) {
>                 /* Shouldn't initialize IR for this interface */
>                 return 0;
> --
> 2.7.4
>