Re: [PATCH V2 2/3] dmaengine: qcom_hidma: add support for the new revision

[Sinan Kaya]

On 11/8/2017 12:12 PM, Timur Tabi wrote:
> On 11/08/2017 10:58 AM, Sinan Kaya wrote:
>> Besides, C compiler also won't let me put two arrays together like this.
>>
>> struct my_struct {
>> ÂÂÂÂstruct some_struct array1[]
>> ÂÂÂÂstruct some_struct array2[]
>> }
> 
> Why not this:
> 
> const struct of_device_id hidma_msi_of_ids[] = {
> ÂÂÂÂ{.compatible = "qcom,hidma-1.1",},
> ÂÂÂÂ{.compatible = "qcom,hidma-1.2",},
> ÂÂÂÂ{},
> },
> 
> static const struct acpi_device_id hidma_msi_acpi_ids[] = {
> ÂÂÂÂ{"QCOM8001", QDF2XXX_V1},
> ÂÂÂÂ{"QCOM8002", QDF2XXX_V2},
> ÂÂÂÂ{},
> };
> 
> struct hidma_cap {
> ÂÂÂÂconst struct of_device_id *of;
> ÂÂÂÂconst struct acpi_device_id *acpi;
> };
> 
> static struct hidma_cap hidma_msi_cap = {
> ÂÂÂÂhidma_msi_of_ids,
> ÂÂÂÂhidma_msi_acpi_ids
> }
> 

I think we are talking styles here. I started with your proposal and wanted to group
the settings together as much as I can for maintenance reasons only because 
I don't have to remember that there are two different arrays that I need to take care
of when I add a new HW in the future.

+static struct hidma_cap hidma_msi_cap = {
+	.of = {
+		{.compatible = "qcom,hidma-1.1",},
+		{.compatible = "qcom,hidma-1.2",},
+		{},
+	},
+
+	.acpi = {
+		{"QCOM8062"},
+		{"QCOM8063"},
+		{},
+	}
+};

I like this better than what you are proposing.

> Keep in mind that you also need to add MODULE_DEVICE_TABLE entries, which you can't really do with your approach.
> 
> MODULE_DEVICE_TABLE(of, hidma_msi_of_ids);
> MODULE_DEVICE_TABLE(acpi, hidma_msi_acpi_ids);
> 

HIDMA capable devices are a subset of the devices that need to be probed. That's also
why I don't touch the device_table.

In the end both approaches work. It is a choice between what is more manageable. That
was the initial objection. I tried to close on this request.

-- 
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.