Re: [PATCH 3/3] perf tools: Removing FLAGS_PYTHON_EMBED/FLAGS_PERL_EMBED variables

[Jiri Olsa]

On Wed, Nov 08, 2017 at 01:06:40PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Wed, Nov 08, 2017 at 11:27:39AM +0100, Jiri Olsa escreveu:
> > There's no user of those.
> 
> [acme@jouet linux]$ find tools/ -type f | xargs grep FLAGS_PYTHON_EMBED
> tools/perf/Makefile.config:  FLAGS_PYTHON_EMBED := $(PYTHON_EMBED_CCOPTS) $(PYTHON_EMBED_LDOPTS)
> tools/build/feature/Makefile:	$(BUILD) -fstack-protector-all -O2 -D_FORTIFY_SOURCE=2 -ldw -lelf -lnuma -lelf -laudit -I/usr/include/slang -lslang $(shell $(PKG_CONFIG) --libs --cflags gtk+-2.0 2>/dev/null) $(FLAGS_PERL_EMBED) $(FLAGS_PYTHON_EMBED) -DPACKAGE='"perf"' -lbfd -ldl -lz -llzma
> tools/build/feature/Makefile:	$(BUILD) $(FLAGS_PYTHON_EMBED)
> [acme@jouet linux]$ 
> 
> Should we remove these?

oops, missed that directory.. thos eneed to stay then ;-) sry

thanks,
jirka

> 
> - Arnaldo
>  
> > Link: http://lkml.kernel.org/n/tip-84jeuwojm21wcjfzvtis636l@xxxxxxxxxxxxxx
> > Signed-off-by: Jiri Olsa <jolsa@xxxxxxxxxx>
> > ---
> >  tools/perf/Makefile.config | 2 --
> >  1 file changed, 2 deletions(-)
> > 
> > diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config
> > index 5e3734e4c1e4..caa7fe26efa9 100644
> > --- a/tools/perf/Makefile.config
> > +++ b/tools/perf/Makefile.config
> > @@ -187,7 +187,6 @@ ifdef PYTHON_CONFIG
> >    ifeq ($(CC_NO_CLANG), 1)
> >      PYTHON_EMBED_CCOPTS := $(filter-out -specs=%,$(PYTHON_EMBED_CCOPTS))
> >    endif
> > -  FLAGS_PYTHON_EMBED := $(PYTHON_EMBED_CCOPTS) $(PYTHON_EMBED_LDOPTS)
> >  endif
> >  
> >  FEATURE_CHECK_CFLAGS-libpython := $(PYTHON_EMBED_CCOPTS)
> > @@ -580,7 +579,6 @@ else
> >    PERL_EMBED_LDFLAGS = $(call strip-libs,$(PERL_EMBED_LDOPTS))
> >    PERL_EMBED_LIBADD = $(call grep-libs,$(PERL_EMBED_LDOPTS))
> >    PERL_EMBED_CCOPTS = $(shell perl -MExtUtils::Embed -e ccopts 2>/dev/null)
> > -  FLAGS_PERL_EMBED=$(PERL_EMBED_CCOPTS) $(PERL_EMBED_LDOPTS)
> >  
> >    ifneq ($(feature-libperl), 1)
> >      CFLAGS += -DNO_LIBPERL
> > -- 
> > 2.13.6