Re: [PATCH] extcon: max8997: Delete an unnecessary variable initialisation in max8997_muic_set_path()

From: Chanwoo Choi
Date: Thu Nov 09 2017 - 04:16:27 EST


Hi,

On 2017ë 11ì 09ì 18:05, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> Date: Thu, 9 Nov 2017 10:00:08 +0100
>
> The variable "ret" will be set to an appropriate value a bit later.
> Thus omit the explicit initialisation at the beginning.
>
> Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> ---
> drivers/extcon/extcon-max8997.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/extcon/extcon-max8997.c b/drivers/extcon/extcon-max8997.c
> index 8152790d72e1..9f30f4929b72 100644
> --- a/drivers/extcon/extcon-max8997.c
> +++ b/drivers/extcon/extcon-max8997.c
> @@ -204,7 +204,7 @@ static int max8997_muic_set_debounce_time(struct max8997_muic_info *info,
> static int max8997_muic_set_path(struct max8997_muic_info *info,
> u8 val, bool attached)
> {
> - int ret = 0;
> + int ret;
> u8 ctrl1, ctrl2 = 0;
>
> if (attached)
>

Applied it.
But, it will be merged to v4.16-rc1.

--
Best Regards,
Chanwoo Choi
Samsung Electronics