Re: [PATCH 30/31] dt-bindings: nds32 CPU Bindings

[Greentime Hu]

2017-11-08 21:18 GMT+08:00 Rob Herring <robh+dt@xxxxxxxxxx>:
> Please Cc the DT list on bindings.

Sorry. I am not sure what you mean.
Do you mean add devicetree@xxxxxxxxxxxxxxx to cc list?

> On Tue, Nov 7, 2017 at 11:55 PM, Greentime Hu <green.hu@xxxxxxxxx> wrote:
>> From: Greentime Hu <greentime@xxxxxxxxxxxxx>
>
> Commit message needed.

Thanks. I will add more commit messages in the next version patch.

>> Signed-off-by: Vincent Chen <vincentc@xxxxxxxxxxxxx>
>> Signed-off-by: Rick Chen <rick@xxxxxxxxxxxxx>
>> Signed-off-by: Zong Li <zong@xxxxxxxxxxxxx>
>> Signed-off-by: Greentime Hu <greentime@xxxxxxxxxxxxx>
>> ---
>>  Documentation/devicetree/bindings/nds32/cpus.txt |   33 ++++++++++++++++++++++
>>  1 file changed, 33 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/nds32/cpus.txt
>>
>> diff --git a/Documentation/devicetree/bindings/nds32/cpus.txt b/Documentation/devicetree/bindings/nds32/cpus.txt
>> new file mode 100644
>> index 0000000..97394cb
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/nds32/cpus.txt
>> @@ -0,0 +1,33 @@
>> +* Andestech Processor Binding
>> +
>> +This binding specifies what properties must be available in the device tree
>> +representation of a Andestech Processor Core, which is the root node in the
>> +tree.
>> +
>> +Required properties:
>> +
>> +       - compatible:
>> +               Usage: required
>> +               Value type: <string>
>> +               Definition: should be one of:
>> +                       "andestech,n13"
>> +                       "andestech,n15"
>> +                       "andestech,d15"
>> +                       "andestech,n10"
>> +                       "andestech,d10"
>
> SMP supported for any of these?

We don't support SMP now.

>> +
>> +    - device_type
>> +               Usage: required
>> +               Value type: <string>
>> +               Definition: must be "cpu"
>> +
>> +* Examples
>> +
>> +/ {
>> +       cpus {
>> +               cpu@0 {
>
> Needs a reg property or drop the unit address.

Thanks.
I will fix it in the next version patch.

>> +                       device_type = "cpu";
>> +                       compatible = "andestech,n13", "andestech,n15";
>
> n13 is a superset of n15?

No, they are independent ones.