Re: [PATCH 2/3] watchdog: jz4780: Allow selection of jz4740-wdt driver

From: Guenter Roeck
Date: Thu Nov 09 2017 - 11:01:55 EST


On Thu, Nov 09, 2017 at 07:47:19AM +0000, James Hogan wrote:
> Hi Wim,
>
> On Fri, Sep 08, 2017 at 08:35:54PM +0200, Mathieu Malaterre wrote:
> > This driver works for jz4740 & jz4780
> >
> > Suggested-by: Maarten ter Huurne <maarten@xxxxxxxxxxxxxx>
> > Signed-off-by: Mathieu Malaterre <malat@xxxxxxxxxx>
>
> I just noticed that though Ralf applied the other two patches in this
> series (defconfig + dt), he hadn't applied this patch.
>
> Please can we have an ack from a watchdog maintainer so this can get
> into 4.15 via the MIPS tree? It could alternatively go via the watchdog
> tree if you prefer.
>

FWIW, according to my logs I did send out a Reviewed-by: some time ago,
which normally means that I expect it to go through the watchdog tree.
I wasn't aware that you wanted the patch to go through the mips tree.
Sorry if I missed that earlier. For the record,

Acked-by: Guenter Roeck <linux@xxxxxxxxxxxx>

since I don't care one way or another.

I assume you want me to drop this and the related patches from my own
watchdpog-next tree to prevent it from showing up in Wim's tree (if
it isn't already there). Is that correct ?

Guenter

> Thanks
> James
>
> > ---
> > drivers/watchdog/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> > index c722cbfdc7e6..ca200d1f310a 100644
> > --- a/drivers/watchdog/Kconfig
> > +++ b/drivers/watchdog/Kconfig
> > @@ -1460,7 +1460,7 @@ config INDYDOG
> >
> > config JZ4740_WDT
> > tristate "Ingenic jz4740 SoC hardware watchdog"
> > - depends on MACH_JZ4740
> > + depends on MACH_JZ4740 || MACH_JZ4780
> > select WATCHDOG_CORE
> > help
> > Hardware driver for the built-in watchdog timer on Ingenic jz4740 SoCs.
> > --
> > 2.11.0
> >
> >