Re: [PATCH] staging: pi433: fix missing break in switch statement.

From: Dan Carpenter
Date: Thu Nov 09 2017 - 16:48:42 EST


On Thu, Nov 09, 2017 at 05:19:55PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> The PI433_IOC_WR_RX_CFG case is missing a break and will fall through
> to the default case and errorenously return -EINVAL. Fix this by
> adding in missing break.
>

Could you fix PI433_IOC_RD_RX_CFG as well? There is a missing return
statement if the copy_to_user() fails we fall through to here and error
out.

regards,
dan carpenter