Re: [PATCH net-next v2] Revert "net: dsa: constify cpu_dp member of dsa_port"

[Vivien Didelot]

Hi David,

Vivien Didelot <vivien.didelot@xxxxxxxxxxxxxxxxxxxx> writes:

> We may have to pass a port's dedicated CPU port to port-wide functions
> such as dsa_port_mdb_add, e.g. when offloading bridge device's MDB.
>
> The DSA port-wide functions currently take a non-const struct dsa_port *
> as first argument so we cannot make cpu_dp const yet, even though it'd
> be more correct. Revert this patch and make cpu_dp non-const again.
>
> This reverts commit 24a9332a58b7f41a0d36c35a2c6897242bffdbc0.

No need to apply this revert, Andrew made the dsa_port_mdb_* functions
take a const dsa_port in his new IGMP patchset so that we can keep the
cpu_dp const, as it should be.


Thanks,

        Vivien