Re: [PATCH v6 0/2] add support for the Samsung S6SY761 touchscreen
From: Dmitry Torokhov
Date: Fri Nov 10 2017 - 13:25:07 EST
On Wed, Nov 08, 2017 at 05:21:03PM +0900, Andi Shyti wrote:
> Hi,
>
> This patchset adds support for the Samsung s6sy761 touchscreen.
>
> Thanks,
> Andi
Applied, thank you.
>
> v5 - v6
> - make a clear logical split between hw initialization and
> resume.
> - fix an inconsistency when applying the maximum x and y
> coordinates (as discussed with Dmitry[*]).
>
> [*] https://www.mail-archive.com/linux-kernel@xxxxxxxxxxxxxxx/msg1528801.html
>
> v4 - v5
> - The previous patch has been split in two parts as requested
> by Rob and added his ack in the dt-binding patch.
> - I tried to fix all the reviews from Dmitry[*]
> - other random cleanups
>
> [*] https://www.mail-archive.com/linux-kernel@xxxxxxxxxxxxxxx/msg1523520.html
>
> v3 - v4
> - fixed a mismatch on the module name
>
> v2 - v3
> - added security check on an unsigned value which can (unlikely)
> get a "negative" value
>
> - in the probe function the interrupt is requested after the
> input device registration in order to avoid checking in the
> interrupt handler whether the input device has been registered
>
> - removed the 'prev_pm_state' variable. Its original meaning
> was to restore the state of the device when coming back from
> sleep mode, but because I removed in patch v2 the low power
> mode, now the device works only in two modes and therefore
> 'prev_pm_state' is not required any longer.
>
> v1 - v2
> - remove the low power functionality as it doesn't bring any
> benefit
> - use get_unaligned_be16 instead of the form 'a << 8 | b'
> - use max_t instead of '? :'
> - use managed 'devm_device_add_group()'
>
>
> Andi Shyti (2):
> dt-bindings: Input: add Samsung S6SY761 touchscreen binding file
> Input: add support for the Samsung S6SY761 touchscreen
>
> .../bindings/input/touchscreen/samsung,s6sy761.txt | 34 ++
> drivers/input/touchscreen/Kconfig | 11 +
> drivers/input/touchscreen/Makefile | 1 +
> drivers/input/touchscreen/s6sy761.c | 564 +++++++++++++++++++++
> 4 files changed, 610 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/input/touchscreen/samsung,s6sy761.txt
> create mode 100644 drivers/input/touchscreen/s6sy761.c
>
> --
> 2.15.0
>
--
Dmitry