Re: [PATCH 4.4 34/46] crypto: xts - Add ECB dependency

[Ben Hutchings]

On Thu, 2017-10-19 at 15:49 +0200, Greg Kroah-Hartman wrote:
> 4.4-stable review patch.ÂÂIf anyone has any objections, please let me
> know.
> 
> ------------------
> 
> From: Milan Broz <gmazyland@xxxxxxxxx>
> 
> 
> [ Upstream commit 12cb3a1c4184f891d965d1f39f8cfcc9ef617647 ]
> 
> Since the
> ÂÂÂcommit f1c131b45410a202eb45cc55980a7a9e4e4b4f40
> ÂÂÂcrypto: xts - Convert to skcipher

That commit went into 4.10, and not any stable branches.  So this fix
doesn't appear to be appropriate for the older branches it was applied
to.

Ben.

> the XTS mode is based on ECB, so the mode must select
> ECB otherwise it can fail to initialize.
> 
> Signed-off-by: Milan Broz <gmazyland@xxxxxxxxx>
> Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Sasha Levin <alexander.levin@xxxxxxxxxxx>
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> ---
> Âcrypto/Kconfig |ÂÂÂÂ1 +
> Â1 file changed, 1 insertion(+)
> 
> --- a/crypto/Kconfig
> +++ b/crypto/Kconfig
> @@ -343,6 +343,7 @@ config CRYPTO_XTS
> Â	select CRYPTO_BLKCIPHER
> Â	select CRYPTO_MANAGER
> Â	select CRYPTO_GF128MUL
> +	select CRYPTO_ECB
> Â	help
> Â	ÂÂXTS: IEEE1619/D16 narrow block cipher use with aes-xts-
> plain,
> Â	ÂÂkey size 256, 384 or 512 bits. This implementation
> currently
> 
> 
> 
-- 
Ben Hutchings
Software Developer, Codethink Ltd.