Re: [PATCH 4/5] linux/smpboot.h: Apply format_template attribute

From: Thomas Gleixner
Date: Sun Nov 12 2017 - 18:07:10 EST


On Sun, 12 Nov 2017, Rasmus Villemoes wrote:

> This serves as human-readable documentation as well as allowing the
> format_template plugin to complain about any static initializers of this
> struct member that do not have the same set of printf specifiers.
>
> Signed-off-by: Rasmus Villemoes <linux@xxxxxxxxxxxxxxxxxx>

Acked-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>

> ---
> include/linux/smpboot.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/smpboot.h b/include/linux/smpboot.h
> index c174844cf663..967285b9637d 100644
> --- a/include/linux/smpboot.h
> +++ b/include/linux/smpboot.h
> @@ -42,7 +42,7 @@ struct smp_hotplug_thread {
> void (*unpark)(unsigned int cpu);
> cpumask_var_t cpumask;
> bool selfparking;
> - const char *thread_comm;
> + const char *thread_comm __format_template("foobar/%u");
> };
>
> int smpboot_register_percpu_thread_cpumask(struct smp_hotplug_thread *plug_thread,
> --
> 2.11.0
>
>