Re: [PATCH 1/2] mfd: twl4030-audio: fix sibling-node lookup
From: Lee Jones
Date: Mon Nov 13 2017 - 04:12:34 EST
On Sat, 11 Nov 2017, Johan Hovold wrote:
> A helper purported to look up a child node based on its name was using
> the wrong of-helper and ended up prematurely freeing the parent of-node
> while leaking any matching node.
>
> To make things worse, any matching node would not even necessarily be a
> child node as the whole device tree was searched depth-first starting at
> the parent.
>
> Fixes: 019a7e6b7b31 ("mfd: twl4030-audio: Add DT support")
> Cc: stable <stable@xxxxxxxxxxxxxxx> # 3.7
> Cc: Peter Ujfalusi <peter.ujfalusi@xxxxxx>
> ---
> drivers/mfd/twl4030-audio.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
For my own reference:
Acked-for-MFD-by: Lee Jones <lee.jones@xxxxxxxxxx>
I'll pick this up later in the cycle.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog