Re: [PATCH 5/5] USB: Add format_template attribute to struct usb_class_driver

From: Greg Kroah-Hartman
Date: Mon Nov 13 2017 - 09:00:36 EST


On Sun, Nov 12, 2017 at 10:19:11PM +0100, Rasmus Villemoes wrote:
> This serves as human-readable documentation as well as allowing the
> format_template plugin to complain about any static initializers of this
> struct member that do not have the same set of printf specifiers.
>
> Signed-off-by: Rasmus Villemoes <linux@xxxxxxxxxxxxxxxxxx>
> ---
> include/linux/usb.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/usb.h b/include/linux/usb.h
> index 9c63792a8134..8d48c0cd1c01 100644
> --- a/include/linux/usb.h
> +++ b/include/linux/usb.h
> @@ -1236,7 +1236,7 @@ extern struct bus_type usb_bus_type;
> * parameters used for them.
> */
> struct usb_class_driver {
> - char *name;
> + char *name __format_template("foobar_%d");
> char *(*devnode)(struct device *dev, umode_t *mode);
> const struct file_operations *fops;
> int minor_base;


Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>