Re: [PATCH] mailbox/omap: unregister mbox class

[Suman Anna]

On 11/11/2017 12:09 PM, Arvind Yadav wrote:
> platform_driver_register() can fail here and we must unregister mbox
> class.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@xxxxxxxxx>

Acked-by: Suman Anna <s-anna@xxxxxx>

regards
Suman

> ---
>  drivers/mailbox/omap-mailbox.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mailbox/omap-mailbox.c b/drivers/mailbox/omap-mailbox.c
> index c5e8b9c..2517038 100644
> --- a/drivers/mailbox/omap-mailbox.c
> +++ b/drivers/mailbox/omap-mailbox.c
> @@ -906,7 +906,11 @@ static int __init omap_mbox_init(void)
>  	mbox_kfifo_size = max_t(unsigned int, mbox_kfifo_size,
>  							sizeof(mbox_msg_t));
>  
> -	return platform_driver_register(&omap_mbox_driver);
> +	err = platform_driver_register(&omap_mbox_driver);
> +	if (err)
> +		class_unregister(&omap_mbox_class);
> +
> +	return err;
>  }
>  subsys_initcall(omap_mbox_init);
>  
>