Re: [PATCH 3/9] ASoC: cs42l56: bindings: sound: Fix reset GPIO name in example DT binding

From: Rob Herring
Date: Mon Nov 13 2017 - 16:20:56 EST


On Wed, Nov 08, 2017 at 03:24:59PM -0600, Andrew F. Davis wrote:
> The binding states the reset GPIO property shall be named
> "cirrus,gpio-nreset" and this is what the driver looks for,
> but the example uses "gpio-reset". Fix this here.
>
> Fixes: 3bb40619aca8 ("ASoC: cs42l56: bindings: sound: Add bindings for CS42L56 CODEC")
>
> Signed-off-by: Andrew F. Davis <afd@xxxxxx>
> ---
> Documentation/devicetree/bindings/sound/cs42l56.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/cs42l56.txt b/Documentation/devicetree/bindings/sound/cs42l56.txt
> index 4feb0eb27ea4..4ba520a28ae8 100644
> --- a/Documentation/devicetree/bindings/sound/cs42l56.txt
> +++ b/Documentation/devicetree/bindings/sound/cs42l56.txt
> @@ -55,7 +55,7 @@ Example:
> codec: codec@4b {
> compatible = "cirrus,cs42l56";
> reg = <0x4b>;
> - gpio-reset = <&gpio 10 0>;
> + cirrus,gpio-nreset = <&gpio 10 0>;

Can we deprecate this and use reset-gpios instead?

> cirrus,chgfreq-divisor = <0x05>;
> cirrus.ain1_ref_cfg;
> cirrus,micbias-lvl = <5>;
> --
> 2.15.0
>