Re: [PATCH 0/7] ALSA: Fine-tuning for several function implementations

From: SF Markus Elfring
Date: Tue Nov 14 2017 - 06:49:45 EST


> Date: Tue, 24 Jan 2017 11:02:34 +0100
>
> Some update suggestions were taken into account
> from static source code analysis.
>
> Markus Elfring (7):
> seq: Delete unnecessary checks in snd_seq_ioctl_query_subs()
> seq: Delete unnecessary checks in snd_seq_ioctl_get_subscription()
> seq: Delete unnecessary checks in snd_seq_ioctl_unsubscribe_port()
> seq: Delete unnecessary checks in snd_seq_ioctl_subscribe_port()
> seq: Adjust 16 function calls together with a variable assignment
> dmasound_core: Move two assignments for the variable "ret" in state_open()
> dmasound_core: Adjust six function calls together with a variable assignment
>
> sound/core/seq/seq_clientmgr.c | 163 ++++++++++++++++++++-----------------
> sound/oss/dmasound/dmasound_core.c | 33 +++++---
> 2 files changed, 109 insertions(+), 87 deletions(-)

Are these update suggestions worth for another look?
https://lkml.org/lkml/2017/1/24/292

Regards,
Markus